Mercurial > public > mercurial-scm > hg-stable
diff hgext/histedit.py @ 36275:f574cc00831a
node: make bin() be a wrapper instead of just an alias
This includes a full backout of 59affe7e and 30d0cb27. Per the review
of the former, we'd rather adapt the API to behave like it used to (at
least for now), and take a second run at it if it shows up in our
performance numbers. I ran perfrevlogindex with and without this
change and it didn't make a measurable difference, so maybe it's fine
(despite my intuition to the contrary).
Differential Revision: https://phab.mercurial-scm.org/D2279
author | Augie Fackler <augie@google.com> |
---|---|
date | Wed, 14 Feb 2018 21:34:12 -0500 |
parents | 59affe7e01d4 |
children | 10de411d7207 |
line wrap: on
line diff
--- a/hgext/histedit.py Fri Feb 16 11:30:18 2018 -0800 +++ b/hgext/histedit.py Wed Feb 14 21:34:12 2018 -0500 @@ -183,7 +183,6 @@ from __future__ import absolute_import -import binascii import errno import os @@ -426,7 +425,7 @@ rulehash = rule.strip().split(' ', 1)[0] try: rev = node.bin(rulehash) - except (TypeError, binascii.Error): + except TypeError: raise error.ParseError("invalid changeset %s" % rulehash) return cls(state, rev)