Mercurial > public > mercurial-scm > hg-stable
diff tests/test-inotify @ 9116:f90bbf1ea09f
inotify: fix issue1375, add a test.
The biggest problem was the data structure, which did not allow changing
a file into a directory or vice versa. This problem is fixed by b55d44719b47.
The walk() method also had an issue in this case:
- we know 'path' as a directory. inotify server sleeps.
- 'path' is deleted
- 'path' is recreated as a file
- the server catches up here, and see the deletion. it instantiates a scan(),
which in its turn calls for walk(repo, path).
- walk() then assumes that 'path' is a directory and calls os.listdir on it,
which raises an OSError(errno.ENOTDIR)
Catch the error, and yield the file instead of the directory contents.
author | Nicolas Dumazet <nicdumz.commits@gmail.com> |
---|---|
date | Mon, 13 Jul 2009 16:49:05 +0200 |
parents | 92c952c4470c |
children | a87bc6e2a907 |
line wrap: on
line diff
--- a/tests/test-inotify Tue May 26 23:00:35 2009 +0900 +++ b/tests/test-inotify Mon Jul 13 16:49:05 2009 +0200 @@ -35,4 +35,19 @@ hg status . cd .. +#issue 1375 +#Testing that we can remove a folder and then add a file with the same name +echo % issue 1375 + +mkdir h +echo h > h/h +hg ci -Am t +hg rm h + +echo h >h +hg add h + +hg status +hg ci -m0 + kill `cat hg.pid`