diff rust/hg-core/src/dirstate.rs @ 42769:fce6dc93a510

rust-dirstate: rust implementation of dirstatemap The `dirstatemap` is one of the last building blocks needed to get to a `dirstate.walk` Rust implementation. Disclaimer: This change is part of a big (10) series of patches, all of which started as one big changeset that took a long time to write. This `dirstatemap` implementation is a compromise in terms of complexity both for me and for the reviewers. I chose to submit this patch right now because while it is not perfect, it works and is simple enough (IMHO) to be reviewed. The Python implementation uses a lot of lazy propertycaches, breaks encapsulation and is used as an iterator in a lot of places, all of which dictated the somewhat unidiomatic patterns in this change. Like written in the comments, rewriting this struct to use the typestate pattern might be a good idea, but this is a good first step. Differential Revision: https://phab.mercurial-scm.org/D6632
author Rapha?l Gom?s <rgomes@octobus.net>
date Wed, 10 Jul 2019 09:56:23 +0200
parents 7ceded4419a3
children 2e1f74cc3350
line wrap: on
line diff
--- a/rust/hg-core/src/dirstate.rs	Tue Jul 09 15:15:54 2019 +0200
+++ b/rust/hg-core/src/dirstate.rs	Wed Jul 10 09:56:23 2019 +0200
@@ -10,6 +10,7 @@
 use std::convert::TryFrom;
 
 pub mod dirs_multiset;
+pub mod dirstate_map;
 pub mod parsers;
 
 #[derive(Debug, PartialEq, Clone)]