Mercurial > public > mercurial-scm > hg-stable
diff mercurial/httppeer.py @ 28530:fd2acc5046f6
http: support sending hgargs via POST body instead of in GET or headers
narrowhg (for its narrow spec) and remotefilelog (for its large batch
requests) would like to be able to make requests with argument sets so
absurdly large that they blow out total request size limit on some
http servers. As a workaround, support stuffing args at the start
of the POST body.
We will probably want to leave this behavior off by default in servers
forever, because it makes the old "POSTs are only for writes"
assumption wrong, which might break some of the simpler authentication
configurations.
| author | Augie Fackler <augie@google.com> |
|---|---|
| date | Fri, 11 Mar 2016 11:37:00 -0500 |
| parents | 50314dc3ae4e |
| children | ae53ecc47414 |
line wrap: on
line diff
--- a/mercurial/httppeer.py Mon Mar 14 21:15:59 2016 -0400 +++ b/mercurial/httppeer.py Fri Mar 11 11:37:00 2016 -0500 @@ -97,7 +97,22 @@ self.ui.debug("sending %s command\n" % cmd) q = [('cmd', cmd)] headersize = 0 - if True: + # Important: don't use self.capable() here or else you end up + # with infinite recursion when trying to look up capabilities + # for the first time. + postargsok = self.caps is not None and 'httppostargs' in self.caps + # TODO: support for httppostargs when data is a file-like + # object rather than a basestring + canmungedata = not data or isinstance(data, basestring) + if postargsok and canmungedata: + strargs = urllib.urlencode(sorted(args.items())) + if strargs: + if not data: + data = strargs + elif isinstance(data, basestring): + data = strargs + data + headers['X-HgArgs-Post'] = len(strargs) + else: if len(args) > 0: httpheader = self.capable('httpheader') if httpheader: