bookmarks: rely on exception for malformed lines Since we already have an exception context open, for other thing, we can simplify the code a bit and rely on exception handling for invalid lines. Speed is not the main motivation for this changes. However as I'm in the middle of benchmarking things we can see a small positive impact. Before: ! wall 0.009358 comb 0.000000 user 0.000000 sys 0.000000 (best of 303) After: ! wall 0.009173 comb 0.010000 user 0.010000 sys 0.000000 (best of 310)

     1

#ifndef _HG_BDIFF_H_

     2

#define _HG_BDIFF_H_

     3

     4

struct bdiff_line {

     5

	int hash, n, e;

     6

	ssize_t len;

     7

	const char *l;

     8

};

     9

    10

struct bdiff_hunk;

    11

struct bdiff_hunk {

    12

	int a1, a2, b1, b2;

    13

	struct bdiff_hunk *next;

    14

};

    15

    16

int bdiff_splitlines(const char *a, ssize_t len, struct bdiff_line **lr);

    17

int bdiff_diff(struct bdiff_line *a, int an, struct bdiff_line *b, int bn,

    18

	struct bdiff_hunk *base);

    19

void bdiff_freehunks(struct bdiff_hunk *l);

    20

    21

#endif