bookmarks: rely on exception for malformed lines Since we already have an exception context open, for other thing, we can simplify the code a bit and rely on exception handling for invalid lines. Speed is not the main motivation for this changes. However as I'm in the middle of benchmarking things we can see a small positive impact. Before: ! wall 0.009358 comb 0.000000 user 0.000000 sys 0.000000 (best of 303) After: ! wall 0.009173 comb 0.010000 user 0.010000 sys 0.000000 (best of 310)

     1

from __future__ import absolute_import

     2

     3

from mercurial.i18n import _

     4

from mercurial import (

     5

        changegroup,

     6

        error,

     7

        extensions

     8

    )

     9

    10

def abort(orig, *args, **kwargs):

    11

    raise error.Abort(_('this is an exercise'))

    12

    13

def uisetup(ui):

    14

    extensions.wrapfunction(changegroup, 'getbundler', abort)