bookmarks: rely on exception for malformed lines Since we already have an exception context open, for other thing, we can simplify the code a bit and rely on exception handling for invalid lines. Speed is not the main motivation for this changes. However as I'm in the middle of benchmarking things we can see a small positive impact. Before: ! wall 0.009358 comb 0.000000 user 0.000000 sys 0.000000 (best of 303) After: ! wall 0.009173 comb 0.010000 user 0.010000 sys 0.000000 (best of 310)

     1

  $ hg init

     2

  $ echo a > a

     3

  $ hg ci -Am t

     4

  adding a

     5

     6

  $ hg mv a b

     7

  $ hg ci -Am t1

     8

  $ hg debugrename b

     9

  b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

    10

    11

  $ hg mv b a

    12

  $ hg ci -Am t2

    13

  $ hg debugrename a

    14

  a renamed from b:37d9b5d994eab34eda9c16b195ace52c7b129980

    15

    16

  $ hg debugrename --rev 1 b

    17

  b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

    18