py3: avoid iterating over a literal bytes in highlight In Python 3, iterating over a bytes literal yields integers. Since we use the value in `text.replace()`, this fails on Python 3 with the following trackback: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgwebdir_mod.py", line 378, in run_wsgi for r in self._runwsgi(req, res): File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgweb_mod.py", line 326, in run_wsgi for r in self._runwsgi(req, res, repo): File "/usr/lib/python3/dist-packages/mercurial/hgweb/hgweb_mod.py", line 449, in _runwsgi return getattr(webcommands, cmd)(rctx) File "/usr/lib/python3/dist-packages/mercurial/hgweb/webcommands.py", line 211, in file return _filerevision(web, webutil.filectx(web.repo, web.req)) File "/usr/lib/python3/dist-packages/hgext/highlight/__init__.py", line 72, in filerevision_highlight pygmentize(web, b'fileline', fctx, web.tmpl) File "/usr/lib/python3/dist-packages/hgext/highlight/__init__.py", line 58, in pygmentize field, fctx, style, tmpl, guessfilenameonly=filenameonly File "/usr/lib/python3/dist-packages/hgext/highlight/highlight.py", line 62, in pygmentize text = text.replace(c, b'') TypeError: a bytes-like object is required, not 'int'

     1

  $ hg init a

     2

  $ cd a

     3

  $ touch empty1

     4

  $ hg add empty1

     5

  $ hg commit -m 'add empty1'

     6

     7

  $ touch empty2

     8

  $ hg add empty2

     9

  $ hg commit -m 'add empty2'

    10

    11

  $ hg up -C 0

    12

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    13

  $ touch empty3

    14

  $ hg add empty3

    15

  $ hg commit -m 'add empty3'

    16

  created new head

    17

    18

  $ hg heads

    19

  changeset:   2:a1cb177e0d44

    20

  tag:         tip

    21

  parent:      0:1e1d9c4e5b64

    22

  user:        test

    23

  date:        Thu Jan 01 00:00:00 1970 +0000

    24

  summary:     add empty3

    25

    26

  changeset:   1:097d2b0e17f6

    27

  user:        test

    28

  date:        Thu Jan 01 00:00:00 1970 +0000

    29

  summary:     add empty2

    30

    31

    32

  $ hg merge 1

    33

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    34

  (branch merge, don't forget to commit)

    35

    36

Before changeset 05257fd28591, we didn't notice the

    37

empty file that came from rev 1:

    38

    39

  $ hg status

    40

  M empty2

    41

  $ hg commit -m merge

    42

  $ hg manifest --debug tip

    43

  b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty1

    44

  b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty2

    45

  b80de5d138758541c5f05265ad144ab9fa86d1db 644   empty3

    46

    47

  $ cd ..