bdiff: don't check border condition in loop This is pretty much a copy of d500ddae7494, just to a different loop. The condition `p == plast` (`plast == a + len - 1`) was only true on the final iteration of the loop. So it was wasteful to check for it on every iteration. We decrease the iteration count by 1 and add an explicit check for `p == plast` after the loop. Again, we see modest wins. From the mozilla-unified repository: $ perfbdiff -m 3041e4d59df2 ! wall 0.035502 comb 0.040000 user 0.040000 sys 0.000000 (best of 100) ! wall 0.030480 comb 0.030000 user 0.030000 sys 0.000000 (best of 100) $ perfbdiff 0e9928989e9c --alldata --count 100 ! wall 4.097394 comb 4.100000 user 4.100000 sys 0.000000 (best of 3) ! wall 3.597798 comb 3.600000 user 3.600000 sys 0.000000 (best of 3) The 2nd example throws a total of ~3.3GB of data at bdiff. This change increases the throughput from ~811 MB/s to ~924 MB/s.

     1

  $ hg init

     2

  $ echo a > a

     3

  $ hg ci -Am t

     4

  adding a

     5

     6

  $ hg mv a b

     7

  $ hg ci -Am t1

     8

  $ hg debugrename b

     9

  b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

    10

    11

  $ hg mv b a

    12

  $ hg ci -Am t2

    13

  $ hg debugrename a

    14

  a renamed from b:37d9b5d994eab34eda9c16b195ace52c7b129980

    15

    16

  $ hg debugrename --rev 1 b

    17

  b renamed from a:b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3

    18