bdiff: don't check border condition in loop This is pretty much a copy of d500ddae7494, just to a different loop. The condition `p == plast` (`plast == a + len - 1`) was only true on the final iteration of the loop. So it was wasteful to check for it on every iteration. We decrease the iteration count by 1 and add an explicit check for `p == plast` after the loop. Again, we see modest wins. From the mozilla-unified repository: $ perfbdiff -m 3041e4d59df2 ! wall 0.035502 comb 0.040000 user 0.040000 sys 0.000000 (best of 100) ! wall 0.030480 comb 0.030000 user 0.030000 sys 0.000000 (best of 100) $ perfbdiff 0e9928989e9c --alldata --count 100 ! wall 4.097394 comb 4.100000 user 4.100000 sys 0.000000 (best of 3) ! wall 3.597798 comb 3.600000 user 3.600000 sys 0.000000 (best of 3) The 2nd example throws a total of ~3.3GB of data at bdiff. This change increases the throughput from ~811 MB/s to ~924 MB/s.

     1

Testing that hghave does not crash when checking features

     2

     3

  $ hghave --test-features 2>/dev/null

     4

     5

Testing hghave extensibility for third party tools

     6

     7

  $ cat > hghaveaddon.py <<EOF

     8

  > import hghave

     9

  > @hghave.check("custom", "custom hghave feature")

    10

  > def has_custom():

    11

  >     return True

    12

  > EOF

    13

    14

(invocation via run-tests.py)

    15

    16

  $ cat > test-hghaveaddon.t <<EOF

    17

  > #require custom

    18

  >   $ echo foo

    19

  >   foo

    20

  > EOF

    21

  $ run-tests.py $HGTEST_RUN_TESTS_PURE test-hghaveaddon.t

    22

  .

    23

  # Ran 1 tests, 0 skipped, 0 warned, 0 failed.

    24

    25

(invocation via command line)

    26

    27

  $ unset TESTDIR

    28

  $ hghave custom

    29

    30

(terminate with exit code 2 at failure of importing hghaveaddon.py)

    31

    32

  $ rm hghaveaddon.*

    33

  $ cat > hghaveaddon.py <<EOF

    34

  > importing this file should cause syntax error

    35

  > EOF

    36

    37

  $ hghave custom

    38

  failed to import hghaveaddon.py from '.': invalid syntax (hghaveaddon.py, line 1)

    39

  [2]