bdiff: don't check border condition in loop This is pretty much a copy of d500ddae7494, just to a different loop. The condition `p == plast` (`plast == a + len - 1`) was only true on the final iteration of the loop. So it was wasteful to check for it on every iteration. We decrease the iteration count by 1 and add an explicit check for `p == plast` after the loop. Again, we see modest wins. From the mozilla-unified repository: $ perfbdiff -m 3041e4d59df2 ! wall 0.035502 comb 0.040000 user 0.040000 sys 0.000000 (best of 100) ! wall 0.030480 comb 0.030000 user 0.030000 sys 0.000000 (best of 100) $ perfbdiff 0e9928989e9c --alldata --count 100 ! wall 4.097394 comb 4.100000 user 4.100000 sys 0.000000 (best of 3) ! wall 3.597798 comb 3.600000 user 3.600000 sys 0.000000 (best of 3) The 2nd example throws a total of ~3.3GB of data at bdiff. This change increases the throughput from ~811 MB/s to ~924 MB/s.

     1

  $ hg init a

     2

  $ cd a

     3

  $ hg init b

     4

  $ echo x > b/x

     5

     6

Should print nothing:

     7

     8

  $ hg add b

     9

  $ hg st

    10

    11

  $ echo y > b/y

    12

  $ hg st

    13

    14

Should fail:

    15

    16

  $ hg st b/x

    17

  abort: path 'b/x' is inside nested repo 'b' (glob)

    18

  [255]

    19

  $ hg add b/x

    20

  abort: path 'b/x' is inside nested repo 'b' (glob)

    21

  [255]

    22

    23

Should fail:

    24

    25

  $ hg add b b/x

    26

  abort: path 'b/x' is inside nested repo 'b' (glob)

    27

  [255]

    28

  $ hg st

    29

    30

Should arguably print nothing:

    31

    32

  $ hg st b

    33

    34

  $ echo a > a

    35

  $ hg ci -Ama a

    36

    37

Should fail:

    38

    39

  $ hg mv a b

    40

  abort: path 'b/a' is inside nested repo 'b' (glob)

    41

  [255]

    42

  $ hg st

    43

    44

  $ cd ..