bdiff: don't check border condition in loop This is pretty much a copy of d500ddae7494, just to a different loop. The condition `p == plast` (`plast == a + len - 1`) was only true on the final iteration of the loop. So it was wasteful to check for it on every iteration. We decrease the iteration count by 1 and add an explicit check for `p == plast` after the loop. Again, we see modest wins. From the mozilla-unified repository: $ perfbdiff -m 3041e4d59df2 ! wall 0.035502 comb 0.040000 user 0.040000 sys 0.000000 (best of 100) ! wall 0.030480 comb 0.030000 user 0.030000 sys 0.000000 (best of 100) $ perfbdiff 0e9928989e9c --alldata --count 100 ! wall 4.097394 comb 4.100000 user 4.100000 sys 0.000000 (best of 3) ! wall 3.597798 comb 3.600000 user 3.600000 sys 0.000000 (best of 3) The 2nd example throws a total of ~3.3GB of data at bdiff. This change increases the throughput from ~811 MB/s to ~924 MB/s.

     1

Issue1678: IndexError when pushing

     2

     3

setting up base repo

     4

  $ hg init a

     5

  $ cd a

     6

  $ touch a

     7

  $ hg ci -Am a

     8

  adding a

     9

  $ cd ..

    10

    11

cloning base repo

    12

  $ hg clone a b

    13

  updating to branch default

    14

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    15

  $ cd b

    16

    17

setting up cset to push

    18

  $ hg up null

    19

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    20

  $ touch a

    21

different msg so we get a clog new entry

    22

  $ hg ci -Am b

    23

  adding a

    24

  created new head

    25

    26

pushing

    27

  $ hg push -f ../a

    28

  pushing to ../a

    29

  searching for changes

    30

  adding changesets

    31

  adding manifests

    32

  adding file changes

    33

  added 1 changesets with 0 changes to 0 files (+1 heads)

    34

    35

  $ cd ..