bdiff: don't check border condition in loop This is pretty much a copy of d500ddae7494, just to a different loop. The condition `p == plast` (`plast == a + len - 1`) was only true on the final iteration of the loop. So it was wasteful to check for it on every iteration. We decrease the iteration count by 1 and add an explicit check for `p == plast` after the loop. Again, we see modest wins. From the mozilla-unified repository: $ perfbdiff -m 3041e4d59df2 ! wall 0.035502 comb 0.040000 user 0.040000 sys 0.000000 (best of 100) ! wall 0.030480 comb 0.030000 user 0.030000 sys 0.000000 (best of 100) $ perfbdiff 0e9928989e9c --alldata --count 100 ! wall 4.097394 comb 4.100000 user 4.100000 sys 0.000000 (best of 3) ! wall 3.597798 comb 3.600000 user 3.600000 sys 0.000000 (best of 3) The 2nd example throws a total of ~3.3GB of data at bdiff. This change increases the throughput from ~811 MB/s to ~924 MB/s.

     1

#!/usr/bin/env python

     2

from __future__ import absolute_import, print_function

     3

     4

from mercurial import (

     5

    commands,

     6

    localrepo,

     7

    ui as uimod,

     8

)

     9

    10

u = uimod.ui()

    11

    12

print('% creating repo')

    13

repo = localrepo.localrepository(u, '.', create=True)

    14

    15

f = open('test.py', 'w')

    16

try:

    17

    f.write('foo\n')

    18

finally:

    19

    f.close

    20

    21

print('% add and commit')

    22

commands.add(u, repo, 'test.py')

    23

commands.commit(u, repo, message='*')

    24

commands.status(u, repo, clean=True)

    25

    26

    27

print('% change')

    28

f = open('test.py', 'w')

    29

try:

    30

    f.write('bar\n')

    31

finally:

    32

    f.close()

    33

    34

# this would return clean instead of changed before the fix

    35

commands.status(u, repo, clean=True, modified=True)