Mercurial > public > mercurial-scm > hg
annotate mercurial/utils/hashutil.py @ 48178:f12a19d03d2c
fix: reduce number of tool executions
By grouping together (path, ctx) pairs according to the inputs they would
provide to fixer tools, we can deduplicate executions of fixer tools to
significantly reduce the amount of time spent running slow tools.
This change does not handle clean files in the working copy, which could still
be deduplicated against the files in the checked out commit. It's a little
harder to do that because the filerev is not available in the workingfilectx
(and it doesn't exist for added files).
Anecdotally, this change makes some real uses cases at Google 10x faster. I
think we were originally hesitant to do this because the benefits weren't
obvious, and implementing it efficiently is kind of tricky. If we simply
memoized the formatter execution function, we would be keeping tons of file
content in memory.
Also included is a regression test for a corner case that I broke with my first
attempt at optimizing this code.
Differential Revision: https://phab.mercurial-scm.org/D11280
author | Danny Hooper <hooper@google.com> |
---|---|
date | Thu, 02 Sep 2021 14:08:45 -0700 |
parents | 521ac0d7047f |
children | 6000f5b25c9b |
rev | line source |
---|---|
44059
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
1 from __future__ import absolute_import |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
2 |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
3 import hashlib |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
4 |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
5 try: |
46785
521ac0d7047f
typing: disable import error warnings that are already handled
Matt Harbison <matt_harbison@yahoo.com>
parents:
44059
diff
changeset
|
6 from ..thirdparty import sha1dc # pytype: disable=import-error |
44059
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
7 |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
8 sha1 = sha1dc.sha1 |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
9 except (ImportError, AttributeError): |
7126d8b8e0e6
hashutil: new package for hashing-related features
Augie Fackler <augie@google.com>
parents:
diff
changeset
|
10 sha1 = hashlib.sha1 |