Mercurial > public > mercurial-scm > hg
comparison mercurial/changelog.py @ 29999:003c41edc5f5
changelog: specify checkambig=True to avoid ambiguity around truncation
If steps below occurs at "the same time in sec", all of mtime, ctime
and size are same between (1) and (3).
1. append data to 00changelog.i (and close transaction)
2. discard appended data by truncation (strip or rollback)
3. append same size but different data to 00changelog.i again
Therefore, cache validation doesn't work after (3) as expected.
To avoid such file stat ambiguity around truncation, this patch
specifies checkambig=True for renaming or opening to write changes out
at finalization.
Even after this patch, avoiding file stat ambiguity of 00changelog.i
around truncation isn't yet completed, because truncation side isn't
aware of this issue.
This is a part of ExactCacheValidationPlan.
https://www.mercurial-scm.org/wiki/ExactCacheValidationPlan
| author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
|---|---|
| date | Thu, 22 Sep 2016 21:51:59 +0900 |
| parents | b5e5ddf48bd2 |
| children | 557454ce854a |
comparison
equal
deleted
inserted
replaced
| 29998:14ad8e2a4abe | 29999:003c41edc5f5 |
|---|---|
| 380 if self._divert: | 380 if self._divert: |
| 381 assert not self._delaybuf | 381 assert not self._delaybuf |
| 382 tmpname = self.indexfile + ".a" | 382 tmpname = self.indexfile + ".a" |
| 383 nfile = self.opener.open(tmpname) | 383 nfile = self.opener.open(tmpname) |
| 384 nfile.close() | 384 nfile.close() |
| 385 self.opener.rename(tmpname, self.indexfile) | 385 self.opener.rename(tmpname, self.indexfile, checkambig=True) |
| 386 elif self._delaybuf: | 386 elif self._delaybuf: |
| 387 fp = self.opener(self.indexfile, 'a') | 387 fp = self.opener(self.indexfile, 'a', checkambig=True) |
| 388 fp.write("".join(self._delaybuf)) | 388 fp.write("".join(self._delaybuf)) |
| 389 fp.close() | 389 fp.close() |
| 390 self._delaybuf = None | 390 self._delaybuf = None |
| 391 self._divert = False | 391 self._divert = False |
| 392 # split when we're done | 392 # split when we're done |