comparison mercurial/httppeer.py @ 37543:01361be9e2dc

wireproto: introduce a reactor for client-side state We have a nice state machine of sorts for reacting to server-side events. Now it is time to implement the client equivalent. We introduce a "clientreactor." It allows callers to request that commands be issued. It has multiple modes of operation to reflect what the underlying transport supports. e.g. for SSH, we can perform wire sends immediately but for HTTP we need to buffer sends until all command requests are received. In addition, SSH allows sending multiple requests as long as the connection is open. But HTTP/1.1 only allows sending request data once. For SSH, we'll have one reactor per connection. For HTTP, we'll have one reactor per HTTP request. But because code that calls wire protocol commands should not be aware of how the underlying transport works, this will all be abstracted away by the peer interface. Our crude HTTP peer has been updated to use the reactor instead of formulating frames directly. No behavior should have changed here and tests seem to confirm that. Basic unit tests for the reactor behavior have been added. Differential Revision: https://phab.mercurial-scm.org/D3223
author Gregory Szorc <gregory.szorc@gmail.com>
date Mon, 09 Apr 2018 15:32:01 -0700
parents aacfca6f9767
children 55b5ba8d4e68
comparison
equal deleted inserted replaced
37542:1ec5ce21cb46 37543:01361be9e2dc
513 r'Content-Type': wireprotoserver.FRAMINGTYPE, 513 r'Content-Type': wireprotoserver.FRAMINGTYPE,
514 } 514 }
515 515
516 # TODO this should be part of a generic peer for the frame-based 516 # TODO this should be part of a generic peer for the frame-based
517 # protocol. 517 # protocol.
518 stream = wireprotoframing.stream(1) 518 reactor = wireprotoframing.clientreactor(hasmultiplesend=False,
519 frames = wireprotoframing.createcommandframes(stream, 1, 519 buffersends=True)
520 name, args) 520
521 521 request, action, meta = reactor.callcommand(name, args)
522 body = b''.join(map(bytes, frames)) 522 assert action == 'noop'
523
524 action, meta = reactor.flushcommands()
525 assert action == 'sendframes'
526
527 body = b''.join(map(bytes, meta['framegen']))
523 req = self._requestbuilder(pycompat.strurl(url), body, headers) 528 req = self._requestbuilder(pycompat.strurl(url), body, headers)
524 req.add_unredirected_header(r'Content-Length', r'%d' % len(body)) 529 req.add_unredirected_header(r'Content-Length', r'%d' % len(body))
525 530
526 # TODO unify this code with httppeer. 531 # TODO unify this code with httppeer.
527 try: 532 try: