Mercurial > public > mercurial-scm > hg
comparison mercurial/util.py @ 2579:0875cda033fd
use __contains__, index or split instead of str.find
str.find return -1 when the substring is not found, -1 evaluate
to True and is a valid index, which can lead to bugs.
Using alternatives when possible makes the code clearer and less
prone to bugs. (and __contains__ is faster in microbenchmarks)
| author | Benoit Boissinot <benoit.boissinot@ens-lyon.org> |
|---|---|
| date | Sun, 09 Jul 2006 01:30:30 +0200 |
| parents | 8cb894370514 |
| children | 00fc88b0b256 |
comparison
equal
deleted
inserted
replaced
| 2578:cf4f0322851d | 2579:0875cda033fd |
|---|---|
| 618 return path | 618 return path |
| 619 | 619 |
| 620 def parse_patch_output(output_line): | 620 def parse_patch_output(output_line): |
| 621 """parses the output produced by patch and returns the file name""" | 621 """parses the output produced by patch and returns the file name""" |
| 622 pf = output_line[14:] | 622 pf = output_line[14:] |
| 623 if pf.startswith("'") and pf.endswith("'") and pf.find(" ") >= 0: | 623 if pf.startswith("'") and pf.endswith("'") and " " in pf: |
| 624 pf = pf[1:-1] # Remove the quotes | 624 pf = pf[1:-1] # Remove the quotes |
| 625 return pf | 625 return pf |
| 626 | 626 |
| 627 def is_exec(f, last): | 627 def is_exec(f, last): |
| 628 """check whether a file is executable""" | 628 """check whether a file is executable""" |