Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 29455:0c741fd6158a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
py3: conditionalize httplib import The httplib library is renamed to http.client in python 3. So the import is conditionalized and a test is added in check-code to warn to use util.httplib
author Pulkit Goyal <7895pulkit@gmail.com>
date Tue, 28 Jun 2016 16:01:53 +0530
parents 7dce56174916
children f1fdd7e7d434
comparison
equal deleted inserted replaced
29449:5b71a8d7f7ff 29455:0c741fd6158a
328 (r'^import SocketServer', "don't use SockerServer, use util.socketserver"), 328 (r'^import SocketServer', "don't use SockerServer, use util.socketserver"),
329 (r'^import urlparse', "don't use urlparse, use util.urlparse"), 329 (r'^import urlparse', "don't use urlparse, use util.urlparse"),
330 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"), 330 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),
331 (r'^import cPickle', "don't use cPickle, use util.pickle"), 331 (r'^import cPickle', "don't use cPickle, use util.pickle"),
332 (r'^import pickle', "don't use pickle, use util.pickle"), 332 (r'^import pickle', "don't use pickle, use util.pickle"),
333 (r'^import httplib', "don't use httplib, use util.httplib"),
333 (r'\.next\(\)', "don't use .next(), use next(...)"), 334 (r'\.next\(\)', "don't use .next(), use next(...)"),
334 335
335 # rules depending on implementation of repquote() 336 # rules depending on implementation of repquote()
336 (r' x+[xpqo%APM][\'"]\n\s+[\'"]x', 337 (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
337 'string join across lines with no space'), 338 'string join across lines with no space'),