mercurial-scm/hg: mercurial/hgweb/webutil.py comparison

hgweb: extract a generator function of _siblings class _siblings will be converted to a plain function.

comparison

equal deleted inserted replaced

-:7738ae638b62
+:0e02eb838b96
 self._revlog = repo.file(path)
 def hex(self, rev):
 return hex(self._changelog.node(self._revlog.linkrev(rev)))
+# TODO: maybe this can be a wrapper class for changectx/filectx list, which
+# yields {'ctx': ctx}
+def _ctxsgen(ctxs):
+for s in ctxs:
+d = {
+'node': s.hex(),
+'rev': s.rev(),
+'user': s.user(),
+'date': s.date(),
+'description': s.description(),
+'branch': s.branch(),
+}
+if util.safehasattr(s, 'path'):
+d['file'] = s.path()
+yield d
 class _siblings(object):
 def __init__(self, siblings=None, hiderev=None):
 if siblings is None:
 siblings = []
 self.siblings = [s for s in siblings if s.node() != nullid]
 if len(self.siblings) == 1 and self.siblings[0].rev() == hiderev:
 self.siblings = []
 def __iter__(self):
-for s in self.siblings:
+return _ctxsgen(self.siblings)
-d = {
-'node': s.hex(),
-'rev': s.rev(),
-'user': s.user(),
-'date': s.date(),
-'description': s.description(),
-'branch': s.branch(),
-}
-if util.safehasattr(s, 'path'):
-d['file'] = s.path()
-yield d
 def __len__(self):
 return len(self.siblings)
 def difffeatureopts(req, ui, section):

Mercurial > public > mercurial-scm > hg