Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 29330:12c97985ddeb

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: make 'ls' pattern less invasive I got false positive at "--tls smtps --certificate ...".
author Yuya Nishihara <yuya@tcha.org>
date Tue, 31 May 2016 21:49:49 +0900
parents 438caf194160
children 844f72885fb9
comparison
equal deleted inserted replaced
29328:60621cecc8c5 29330:12c97985ddeb
120 (r'/bin/', "don't use explicit paths for tools"), 120 (r'/bin/', "don't use explicit paths for tools"),
121 (r'[^\n]\Z', "no trailing newline"), 121 (r'[^\n]\Z', "no trailing newline"),
122 (r'export .*=', "don't export and assign at once"), 122 (r'export .*=', "don't export and assign at once"),
123 (r'^source\b', "don't use 'source', use '.'"), 123 (r'^source\b', "don't use 'source', use '.'"),
124 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), 124 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
125 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), 125 (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
126 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 126 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
127 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 127 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
128 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), 128 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
129 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"), 129 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),
130 (r'^alias\b.*=', "don't use alias, use a function"), 130 (r'^alias\b.*=', "don't use alias, use a function"),