Mercurial > public > mercurial-scm > hg
comparison mercurial/localrepo.py @ 33556:22371eabb3b1
sparse: add a requirement when a repository uses sparse (BC)
The presence of a sparse checkout can confuse legacy clients or
clients without sparse enabled for reasons that should be obvious.
This commit introduces a new repository requirement that tracks
whether sparse is enabled. The requirement is added when a sparse
config is activated and removed when the sparse config is reset.
The localrepository constructor has been taught to not open repos
with this requirement unless the sparse feature is enabled. It yields
a more actionable error message than what you would get if the
lockout were handled strictly at the requirements verification phase.
Old clients that aren't sparse aware will see the generic
"repository requires features unknown to this Mercurial" error,
however.
The new requirement has "exp" in its name to reflect the
experimental nature of sparse. There's a chance that the eventual
non-experimental feature won't change significantly and we could
have squatted on the "sparse" requirement without ill effect. If
that happens, we can teach new clients to still recognize the old
name. But I suspect we'll sneak in some BC and we'll want a new
requirement to convey new meaning.
Differential Revision: https://phab.mercurial-scm.org/D110
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Mon, 17 Jul 2017 11:45:38 -0700 |
parents | b47fef6d2365 |
children | 377e8ddaebef fda0867cfe03 |
comparison
equal
deleted
inserted
replaced
33555:6755b719048c | 33556:22371eabb3b1 |
---|---|
286 'store', | 286 'store', |
287 'fncache', | 287 'fncache', |
288 'shared', | 288 'shared', |
289 'relshared', | 289 'relshared', |
290 'dotencode', | 290 'dotencode', |
291 'exp-sparse', | |
291 } | 292 } |
292 openerreqs = { | 293 openerreqs = { |
293 'revlogv1', | 294 'revlogv1', |
294 'generaldelta', | 295 'generaldelta', |
295 'treemanifest', | 296 'treemanifest', |
416 _('.hg/sharedpath points to nonexistent directory %s') % s) | 417 _('.hg/sharedpath points to nonexistent directory %s') % s) |
417 self.sharedpath = s | 418 self.sharedpath = s |
418 except IOError as inst: | 419 except IOError as inst: |
419 if inst.errno != errno.ENOENT: | 420 if inst.errno != errno.ENOENT: |
420 raise | 421 raise |
422 | |
423 if 'exp-sparse' in self.requirements and not sparse.enabled: | |
424 raise error.RepoError(_('repository is using sparse feature but ' | |
425 'sparse is not enabled; enable the ' | |
426 '"sparse" extensions to access')) | |
421 | 427 |
422 self.store = store.store( | 428 self.store = store.store( |
423 self.requirements, self.sharedpath, vfsmod.vfs) | 429 self.requirements, self.sharedpath, vfsmod.vfs) |
424 self.spath = self.store.path | 430 self.spath = self.store.path |
425 self.svfs = self.store.vfs | 431 self.svfs = self.store.vfs |