Mercurial > public > mercurial-scm > hg
comparison contrib/check-code.py @ 20242:2dad90bdf29d
check-code: drop now unused check-code-ignore
Using check-code-ignore to skip the failures on a line has several
disadvantages:
* It skips all check-code failures on a line, not only the one it was created
for.
* It does not give any hint for which rule it was added, making it difficult to
see when it is not needed anymore.
So drop this pragma in favor of better alternatives promoted before.
| author | Simon Heimberg <simohe@besonet.ch> |
|---|---|
| date | Tue, 07 Jan 2014 22:29:51 +0100 |
| parents | 8071b4eddefa |
| children | cc09cfea3dd4 |
comparison
equal
deleted
inserted
replaced
| 20241:8071b4eddefa | 20242:2dad90bdf29d |
|---|---|
| 492 break | 492 break |
| 493 pos += step | 493 pos += step |
| 494 n += 1 | 494 n += 1 |
| 495 l = prelines[n] | 495 l = prelines[n] |
| 496 | 496 |
| 497 if "check-code" "-ignore" in l: | 497 if ignore and re.search(ignore, l, re.MULTILINE): |
| 498 if debug: | |
| 499 print "Skipping %s for %s:%s (check-code" "-ignore)" % ( | |
| 500 name, f, n) | |
| 501 continue | |
| 502 elif ignore and re.search(ignore, l, re.MULTILINE): | |
| 503 continue | 498 continue |
| 504 bd = "" | 499 bd = "" |
| 505 if blame: | 500 if blame: |
| 506 bd = 'working directory' | 501 bd = 'working directory' |
| 507 if not blamecache: | 502 if not blamecache: |