comparison mercurial/localrepo.py @ 50059:3236643066c4

dirstate: warn if we write to the dirstate without holding the wlock Writing the dirstate without holding the wlock can race with other update and overwrite important change. The comment questionning the current state of things was right, we should the `wlock` should always cover the dirstate. (Yes, this is me, agreeing with myself, half a decade later).
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Tue, 13 Dec 2022 03:55:14 +0100
parents d1215f905818
children 81870c92c293
comparison
equal deleted inserted replaced
50058:d1215f905818 50059:3236643066c4
1321 b'hgrc', 1321 b'hgrc',
1322 b'requires', 1322 b'requires',
1323 # XXX cache is a complicatged business someone 1323 # XXX cache is a complicatged business someone
1324 # should investigate this in depth at some point 1324 # should investigate this in depth at some point
1325 b'cache/', 1325 b'cache/',
1326 # XXX shouldn't be dirstate covered by the wlock?
1327 b'dirstate',
1328 # XXX bisect was still a bit too messy at the time 1326 # XXX bisect was still a bit too messy at the time
1329 # this changeset was introduced. Someone should fix 1327 # this changeset was introduced. Someone should fix
1330 # the remainig bit and drop this line 1328 # the remainig bit and drop this line
1331 b'bisect.state', 1329 b'bisect.state',
1332 } 1330 }