Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 19031:341083b02d1b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: add check for lock release order
author Matt Mackall <mpm@selenic.com>
date Wed, 17 Apr 2013 14:38:02 -0500
parents 170fc0949fb6
children 5e4491c114b2
comparison
equal deleted inserted replaced
19030:48d6f436363e 19031:341083b02d1b
222 (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"), 222 (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
223 (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'), 223 (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),
224 (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"), 224 (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"),
225 (r'ui\.(status|progress|write|note|warn)\([\'\"]x', 225 (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
226 "missing _() in ui message (use () to hide false-positives)"), 226 "missing _() in ui message (use () to hide false-positives)"),
227 (r'release\(.*wlock, .*lock\)', "wrong lock release order"),
227 ], 228 ],
228 # warnings 229 # warnings
229 [ 230 [
230 ] 231 ]
231 ] 232 ]