Mercurial > public > mercurial-scm > hg
comparison contrib/check-code.py @ 34573:3e4b7861c1c5
contrib: add check-code rule banning use of readlink
readlink doesn't always exist, such as on Solaris-derived platforms.
Differential Revision: https://phab.mercurial-scm.org/D1000
author | Augie Fackler <augie@google.com> |
---|---|
date | Wed, 11 Oct 2017 03:48:11 -0700 |
parents | b521b3a79afd |
children | a679aa582d8d |
comparison
equal
deleted
inserted
replaced
34572:d6d10771950c | 34573:3e4b7861c1c5 |
---|---|
201 'mark $LOCALIP output lines with (glob) to help tests in BSD jails'), | 201 'mark $LOCALIP output lines with (glob) to help tests in BSD jails'), |
202 (r'^ (cat|find): .*: No such file or directory', | 202 (r'^ (cat|find): .*: No such file or directory', |
203 'use test -f to test for file existence'), | 203 'use test -f to test for file existence'), |
204 (r'^ diff -[^ -]*p', | 204 (r'^ diff -[^ -]*p', |
205 "don't use (external) diff with -p for portability"), | 205 "don't use (external) diff with -p for portability"), |
206 (r' readlink ', 'use readlink.py instead of readlink'), | |
206 (r'^ [-+][-+][-+] .* [-+]0000 \(glob\)', | 207 (r'^ [-+][-+][-+] .* [-+]0000 \(glob\)', |
207 "glob timezone field in diff output for portability"), | 208 "glob timezone field in diff output for portability"), |
208 (r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@', | 209 (r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@', |
209 "use '@@ -N* +N,n @@ (glob)' style chunk header for portability"), | 210 "use '@@ -N* +N,n @@ (glob)' style chunk header for portability"), |
210 (r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@', | 211 (r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@', |