Mercurial > public > mercurial-scm > hg
comparison mercurial/revset.py @ 25550:3e9049876ace
revset: gratuitous code move in '_children'
As 'cs' is empty as the time of the conditional, we can just return an empty
'baseset' and create the variable later.
| author | Pierre-Yves David <pierre-yves.david@fb.com> |
|---|---|
| date | Thu, 11 Jun 2015 14:27:52 -0700 |
| parents | f93ff3ab8d14 |
| children | c1d163ce7394 |
comparison
equal
deleted
inserted
replaced
| 25549:f93ff3ab8d14 | 25550:3e9049876ace |
|---|---|
| 612 return True | 612 return True |
| 613 | 613 |
| 614 return subset.filter(matches) | 614 return subset.filter(matches) |
| 615 | 615 |
| 616 def _children(repo, narrow, parentset): | 616 def _children(repo, narrow, parentset): |
| 617 if not parentset: | |
| 618 return baseset() | |
| 617 cs = set() | 619 cs = set() |
| 618 if not parentset: | |
| 619 return baseset(cs) | |
| 620 pr = repo.changelog.parentrevs | 620 pr = repo.changelog.parentrevs |
| 621 # XXX this should be 'parentset.min()' assuming 'parentset' is a smartset | 621 # XXX this should be 'parentset.min()' assuming 'parentset' is a smartset |
| 622 # (and if it is not, it should.) | 622 # (and if it is not, it should.) |
| 623 minrev = min(parentset) | 623 minrev = min(parentset) |
| 624 for r in narrow: | 624 for r in narrow: |