mercurial-scm/hg: mercurial/revset.py comparison

revset: define table of sort() key functions This should be more readable than big "if" branch.

comparison

equal deleted inserted replaced

-:22625884b15c
+:3f9e68864ccc
 if 0 <= p and p in s:
 return False
 return True
 return subset & s.filter(filter, condrepr='<roots>')
+_sortkeyfuncs = {
+'rev': lambda c: c.rev(),
+'branch': lambda c: c.branch(),
+'desc': lambda c: c.description(),
+'user': lambda c: c.user(),
+'author': lambda c: c.user(),
+'date': lambda c: c.date()[0],
+}
 @predicate('sort(set[, [-]key...])', safe=True)
 def sort(repo, subset, x):
 """Sort set by keys. The default sort order is ascending, specify a key
 as ``-key`` to sort in descending order.
 for k in reversed(keys):
 fk = k
 reverse = (k[0] == '-')
 if reverse:
 k = k[1:]
-if k == 'rev':
+try:
-ctxs.sort(key=lambda c: c.rev(), reverse=reverse)
+ctxs.sort(key=_sortkeyfuncs[k], reverse=reverse)
-elif k == 'branch':
+except KeyError:
-ctxs.sort(key=lambda c: c.branch(), reverse=reverse)
-elif k == 'desc':
-ctxs.sort(key=lambda c: c.description(), reverse=reverse)
-elif k in 'user author':
-ctxs.sort(key=lambda c: c.user(), reverse=reverse)
-elif k == 'date':
-ctxs.sort(key=lambda c: c.date()[0], reverse=reverse)
-else:
 raise error.ParseError(_("unknown sort key %r") % fk)
 return baseset([c.rev() for c in ctxs])
 @predicate('subrepo([pattern])')
 def subrepo(repo, subset, x):

Mercurial > public > mercurial-scm > hg