Mercurial > public > mercurial-scm > hg
comparison mercurial/merge.py @ 45584:4c8a93ec6908
merge: store commitinfo if these is a dc or cd conflict
delete-changed or changed-delete conflicts can either be resolved by mergetool,
if some tool is passed and using or by user choose something on prompt or user
doing some `hg revert` after choosing the file to remain conflicted.
If the user decides to keep the changed side, on commit we just reuse the parent
filenode. This is mostly fine unless we are in a distributed environment and
people are doing criss-cross merges.
Since, we don't have recursive merges or any other way of describing the end
result of the merge was an explicit choice and it should be differentiated from
it's ancestors, merge algo during criss-cross merges fails to take in account
the explicit choice made by user and end up with a what-can-be-said-wrong-merge.
The solution which we are trying to fix this is by creating a filenode on commit
instead of reusing the parent filenode. This helps differentiate between
pre-merged filenode and post-merge filenode and kind of tells about the choice
user made.
To implement creating new filenode functionality, we store info about these
files in mergestate so that we can read them on commit and force create a new
filenode.
Differential Revision: https://phab.mercurial-scm.org/D8988
author | Pulkit Goyal <7895pulkit@gmail.com> |
---|---|
date | Thu, 03 Sep 2020 13:44:06 +0530 |
parents | 76d79b80d953 |
children | 768412472663 |
comparison
equal
deleted
inserted
replaced
45583:9f14bb4d59ea | 45584:4c8a93ec6908 |
---|---|
907 f, | 907 f, |
908 mergestatemod.ACTION_CHANGED_DELETED, | 908 mergestatemod.ACTION_CHANGED_DELETED, |
909 (f, None, f, False, pa.node()), | 909 (f, None, f, False, pa.node()), |
910 b'prompt changed/deleted', | 910 b'prompt changed/deleted', |
911 ) | 911 ) |
912 if branchmerge: | |
913 mresult.addcommitinfo( | |
914 f, b'merge-removal-candidate', b'yes' | |
915 ) | |
912 elif n1 == addednodeid: | 916 elif n1 == addednodeid: |
913 # This file was locally added. We should forget it instead of | 917 # This file was locally added. We should forget it instead of |
914 # deleting it. | 918 # deleting it. |
915 mresult.addfile( | 919 mresult.addfile( |
916 f, mergestatemod.ACTION_FORGET, None, b'remote deleted', | 920 f, mergestatemod.ACTION_FORGET, None, b'remote deleted', |
1016 f, | 1020 f, |
1017 mergestatemod.ACTION_DELETED_CHANGED, | 1021 mergestatemod.ACTION_DELETED_CHANGED, |
1018 (None, f, f, False, pa.node()), | 1022 (None, f, f, False, pa.node()), |
1019 b'prompt deleted/changed', | 1023 b'prompt deleted/changed', |
1020 ) | 1024 ) |
1025 if branchmerge: | |
1026 mresult.addcommitinfo( | |
1027 f, b'merge-removal-candidate', b'yes' | |
1028 ) | |
1021 else: | 1029 else: |
1022 mresult.addfile( | 1030 mresult.addfile( |
1023 f, | 1031 f, |
1024 mergestatemod.ACTION_KEEP_ABSENT, | 1032 mergestatemod.ACTION_KEEP_ABSENT, |
1025 None, | 1033 None, |