Mercurial > public > mercurial-scm > hg
comparison mercurial/util.py @ 31567:4ebecf331d7d
util: use urlreq.unquote
pycompat.urlreq.unquote and pycompat.urlunquote effectively alias the
same thing. pycompat.urlunquote is only used once in the code base.
So let's switch to urlreq.unquote.
"Effectively" in the above paragraph is because pycompat.urlreq.unquote
aliases urllib.unquote and pycompat.urlunquote aliases urlparse.unquote
on Python 2. You might think one of urllib.unquote and urlparse.unquote
is an alias to the other, but you would be incorrect. In fact, these
functions are copies of each other. There is even a comment in the
CPython source code saying to keep them in sync. You can't make this
up.
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Tue, 21 Mar 2017 22:23:11 -0700 |
| parents | bd9daafbf87c |
| children | 55c6788c54e2 |
comparison
equal
deleted
inserted
replaced
| 31566:c6df6a23dfe5 | 31567:4ebecf331d7d |
|---|---|
| 2635 # leave the query string escaped | 2635 # leave the query string escaped |
| 2636 for a in ('user', 'passwd', 'host', 'port', | 2636 for a in ('user', 'passwd', 'host', 'port', |
| 2637 'path', 'fragment'): | 2637 'path', 'fragment'): |
| 2638 v = getattr(self, a) | 2638 v = getattr(self, a) |
| 2639 if v is not None: | 2639 if v is not None: |
| 2640 setattr(self, a, pycompat.urlunquote(v)) | 2640 setattr(self, a, urlreq.unquote(v)) |
| 2641 | 2641 |
| 2642 def __repr__(self): | 2642 def __repr__(self): |
| 2643 attrs = [] | 2643 attrs = [] |
| 2644 for a in ('scheme', 'user', 'passwd', 'host', 'port', 'path', | 2644 for a in ('scheme', 'user', 'passwd', 'host', 'port', 'path', |
| 2645 'query', 'fragment'): | 2645 'query', 'fragment'): |