contrib/check-code.py
branchstable
changeset 16487 4fe874697a4d
parent 16486 ac987a9d8d49
child 16494 e1f0305eabe4
equal deleted inserted replaced
16486:ac987a9d8d49 16487:4fe874697a4d
    93     (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
    93     (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
    94     (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
    94     (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
    95     (uprefix + r'.*\|\| echo.*(fail|error)',
    95     (uprefix + r'.*\|\| echo.*(fail|error)',
    96      "explicit exit code checks unnecessary"),
    96      "explicit exit code checks unnecessary"),
    97     (uprefix + r'set -e', "don't use set -e"),
    97     (uprefix + r'set -e', "don't use set -e"),
       
    98     (uprefix + r'\s', "don't indent commands, use > for continued lines"),
    98     (uprefixc + r'( *)\t', "don't use tabs to indent"),
    99     (uprefixc + r'( *)\t', "don't use tabs to indent"),
    99     (uprefixc + r'.*do\s*true;\s*done',
   100     (uprefixc + r'.*do\s*true;\s*done',
   100      "don't use true as loop body, use sleep 0"),
   101      "don't use true as loop body, use sleep 0"),
   101   ],
   102   ],
   102   # warnings
   103   # warnings