Mercurial > public > mercurial-scm > hg
comparison mercurial/simplemerge.py @ 48509:5151b0f6519e
simplemerge: make `localorother` a "mode" instead of a separate thing
`simplemerge()` takes a `mode` argument, which can be "union", "merge"
or "mergediff", and a `localorother` argument, which can be `None`,
"local", or "other". The two options are not at all orthogonal -- most
combinations don't make sense. Also, at least "union", "local", and
"other" are very closely related. Therefore, it makes sense to combine
them into one.
It probably makes sense to split the `mode` argument into `resolve`
and `marker_style`, where the former can be `None`, "union", "local",
or "other", and the latter can be "merge", "merge3", "mergediff", or
"minimize". This is a good step in that direction whether or not we
end up doing that.
Differential Revision: https://phab.mercurial-scm.org/D11887
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 07 Dec 2021 17:48:50 -0800 |
parents | fa159bb463e6 |
children | fb691fa90807 |
comparison
equal
deleted
inserted
replaced
48508:fa159bb463e6 | 48509:5151b0f6519e |
---|---|
514 except error.Abort: | 514 except error.Abort: |
515 return 1 | 515 return 1 |
516 | 516 |
517 m3 = Merge3Text(basetext, localtext, othertext) | 517 m3 = Merge3Text(basetext, localtext, othertext) |
518 extrakwargs = { | 518 extrakwargs = { |
519 "localorother": opts.get("localorother", None), | 519 "localorother": None, |
520 'minimize': True, | 520 'minimize': True, |
521 } | 521 } |
522 if mode == b'union': | 522 if mode == b'union': |
523 extrakwargs['start_marker'] = None | 523 extrakwargs['start_marker'] = None |
524 extrakwargs['mid_marker'] = None | 524 extrakwargs['mid_marker'] = None |
525 extrakwargs['end_marker'] = None | 525 extrakwargs['end_marker'] = None |
526 elif mode == b'local': | |
527 extrakwargs['localorother'] = b'local' | |
528 elif mode == b'other': | |
529 extrakwargs['localorother'] = b'other' | |
526 elif name_base is not None: | 530 elif name_base is not None: |
527 extrakwargs['base_marker'] = b'|||||||' | 531 extrakwargs['base_marker'] = b'|||||||' |
528 extrakwargs['name_base'] = name_base | 532 extrakwargs['name_base'] = name_base |
529 extrakwargs['minimize'] = False | 533 extrakwargs['minimize'] = False |
530 | 534 |