comparison mercurial/changelog.py @ 30000:557454ce854a

changelog: specify checkambig=True to revlog.__init__, to avoid ambiguity If steps below occurs at "the same time in sec", all of mtime, ctime and size are same between (1) and (3). 1. append data to 00changelog.i (and close transaction) 2. discard appended data by truncation (strip or rollback) 3. append same size but different data to 00changelog.i again Therefore, cache validation doesn't work after (3) as expected. To avoid such file stat ambiguity around truncation, this patch specifies checkambig=True to revlog.__init__(). This makes revlog write changes out with checkambig=True. Even though changes of 00changelog.i themselves are written out at changelog._finalize(), this checkambig=True is needed, because revlog.checkinlinesize(), which is invoked at the end of changelog._finalize(), might replace already changed 00changelog.i by converted one. Even after this patch, avoiding file stat ambiguity of 00changelog.i around truncation isn't yet completed, because truncation side isn't aware of this issue. This is a part of ExactCacheValidationPlan. https://www.mercurial-scm.org/wiki/ExactCacheValidationPlan
author FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
date Thu, 22 Sep 2016 21:51:59 +0900
parents 003c41edc5f5
children b7a966ce89ed
comparison
equal deleted inserted replaced
29999:003c41edc5f5 30000:557454ce854a
255 def description(self): 255 def description(self):
256 return encoding.tolocal(self._text[self._offsets[3] + 2:]) 256 return encoding.tolocal(self._text[self._offsets[3] + 2:])
257 257
258 class changelog(revlog.revlog): 258 class changelog(revlog.revlog):
259 def __init__(self, opener): 259 def __init__(self, opener):
260 revlog.revlog.__init__(self, opener, "00changelog.i") 260 revlog.revlog.__init__(self, opener, "00changelog.i",
261 checkambig=True)
261 if self._initempty: 262 if self._initempty:
262 # changelogs don't benefit from generaldelta 263 # changelogs don't benefit from generaldelta
263 self.version &= ~revlog.REVLOGGENERALDELTA 264 self.version &= ~revlog.REVLOGGENERALDELTA
264 self._generaldelta = False 265 self._generaldelta = False
265 self._realopener = opener 266 self._realopener = opener