comparison mercurial/util.py @ 47079:5b3513177f2b stable

util: avoid echoing the password to the console on Windows py3 (issue6446) The `getpass.getpass()` implementation on Windows first checks if `sys.stdin` and `sys.__stdin__` are the same object. It's not on py3 because the former is replaced in dispatch.py with something that doesn't normalize '\n' to '\r\n'. When they aren't the same object, it simply calls `sys.stdin.readline()` instead of the mscvrt functions that read the input characters before they are echoed. This simply copies the `getpass.win_getpass()` implementation without the stdin check, and byteifies around the edges. I'm not sure if there's a reasonable replacement for the check that we could implement. When echoing input into the hg command, the `ui.interactive()` check causes `ui.getpass()` to bail before getting here. If the proper config switches are used to bypass that and call this, the process stalls until '\n' is input into the console. So there could be a deadlock here when run by another command if the wrong config settings are applied. Differential Revision: https://phab.mercurial-scm.org/D10708
author Matt Harbison <matt_harbison@yahoo.com>
date Wed, 12 May 2021 12:41:52 -0400
parents f38bf44e077f
children bcafcd779d2e
comparison
equal deleted inserted replaced
47068:3af293735d0f 47079:5b3513177f2b
104 checklink = platform.checklink 104 checklink = platform.checklink
105 copymode = platform.copymode 105 copymode = platform.copymode
106 expandglobs = platform.expandglobs 106 expandglobs = platform.expandglobs
107 getfsmountpoint = platform.getfsmountpoint 107 getfsmountpoint = platform.getfsmountpoint
108 getfstype = platform.getfstype 108 getfstype = platform.getfstype
109 get_password = platform.get_password
109 groupmembers = platform.groupmembers 110 groupmembers = platform.groupmembers
110 groupname = platform.groupname 111 groupname = platform.groupname
111 isexec = platform.isexec 112 isexec = platform.isexec
112 isowner = platform.isowner 113 isowner = platform.isowner
113 listdir = osutil.listdir 114 listdir = osutil.listdir