mercurial-scm/hg: mercurial/fileset.py comparison

comparison mercurial/fileset.py @ 38863:61ab546b71c3

fileset: introduce weight constants for readability These constants are defined in the filesetlang module since it's the bottommost module depending on WEIGHT_CHECK_FILENAME, and extensions will be likely to import it to process function arguments. Credit for the naming goes to Augie Fackler.

author	Yuya Nishihara <yuya@tcha.org>
date	Sat, 04 Aug 2018 17:08:33 +0900
parents	bfd5def3fe02
children	899b4c74209c

comparison

equal deleted inserted replaced

-:1ff45c518e6f
+:61ab546b71c3
 )
 from .utils import (
 stringutil,
 )
+# common weight constants
+_WEIGHT_CHECK_FILENAME = filesetlang.WEIGHT_CHECK_FILENAME
+_WEIGHT_READ_CONTENTS = filesetlang.WEIGHT_READ_CONTENTS
+_WEIGHT_STATUS = filesetlang.WEIGHT_STATUS
+_WEIGHT_STATUS_THOROUGH = filesetlang.WEIGHT_STATUS_THOROUGH
 # helpers for processing parsed tree
 getsymbol = filesetlang.getsymbol
 getstring = filesetlang.getstring
 _getkindpat = filesetlang.getkindpat
 getpattern = filesetlang.getpattern
 # filesets using matchctx.status()
 _statuscallers = set()
 predicate = registrar.filesetpredicate()
-@predicate('modified()', callstatus=True, weight=10)
+@predicate('modified()', callstatus=True, weight=_WEIGHT_STATUS)
 def modified(mctx, x):
 """File that is modified according to :hg:`status`.
 """
 # i18n: "modified" is a keyword
 getargs(x, 0, 0, _("modified takes no arguments"))
 s = set(mctx.status().modified)
 return mctx.predicate(s.__contains__, predrepr='modified')
-@predicate('added()', callstatus=True, weight=10)
+@predicate('added()', callstatus=True, weight=_WEIGHT_STATUS)
 def added(mctx, x):
 """File that is added according to :hg:`status`.
 """
 # i18n: "added" is a keyword
 getargs(x, 0, 0, _("added takes no arguments"))
 s = set(mctx.status().added)
 return mctx.predicate(s.__contains__, predrepr='added')
-@predicate('removed()', callstatus=True, weight=10)
+@predicate('removed()', callstatus=True, weight=_WEIGHT_STATUS)
 def removed(mctx, x):
 """File that is removed according to :hg:`status`.
 """
 # i18n: "removed" is a keyword
 getargs(x, 0, 0, _("removed takes no arguments"))
 s = set(mctx.status().removed)
 return mctx.predicate(s.__contains__, predrepr='removed')
-@predicate('deleted()', callstatus=True, weight=10)
+@predicate('deleted()', callstatus=True, weight=_WEIGHT_STATUS)
 def deleted(mctx, x):
 """Alias for ``missing()``.
 """
 # i18n: "deleted" is a keyword
 getargs(x, 0, 0, _("deleted takes no arguments"))
 s = set(mctx.status().deleted)
 return mctx.predicate(s.__contains__, predrepr='deleted')
-@predicate('missing()', callstatus=True, weight=10)
+@predicate('missing()', callstatus=True, weight=_WEIGHT_STATUS)
 def missing(mctx, x):
 """File that is missing according to :hg:`status`.
 """
 # i18n: "missing" is a keyword
 getargs(x, 0, 0, _("missing takes no arguments"))
 s = set(mctx.status().deleted)
 return mctx.predicate(s.__contains__, predrepr='deleted')
-@predicate('unknown()', callstatus=True, weight=50)
+@predicate('unknown()', callstatus=True, weight=_WEIGHT_STATUS_THOROUGH)
 def unknown(mctx, x):
 """File that is unknown according to :hg:`status`."""
 # i18n: "unknown" is a keyword
 getargs(x, 0, 0, _("unknown takes no arguments"))
 s = set(mctx.status().unknown)
 return mctx.predicate(s.__contains__, predrepr='unknown')
-@predicate('ignored()', callstatus=True, weight=50)
+@predicate('ignored()', callstatus=True, weight=_WEIGHT_STATUS_THOROUGH)
 def ignored(mctx, x):
 """File that is ignored according to :hg:`status`."""
 # i18n: "ignored" is a keyword
 getargs(x, 0, 0, _("ignored takes no arguments"))
 s = set(mctx.status().ignored)
 return mctx.predicate(s.__contains__, predrepr='ignored')
-@predicate('clean()', callstatus=True, weight=10)
+@predicate('clean()', callstatus=True, weight=_WEIGHT_STATUS)
 def clean(mctx, x):
 """File that is clean according to :hg:`status`.
 """
 # i18n: "clean" is a keyword
 getargs(x, 0, 0, _("clean takes no arguments"))
 """File that is under Mercurial control."""
 # i18n: "tracked" is a keyword
 getargs(x, 0, 0, _("tracked takes no arguments"))
 return mctx.predicate(mctx.ctx.__contains__, predrepr='tracked')
-@predicate('binary()', weight=30)
+@predicate('binary()', weight=_WEIGHT_READ_CONTENTS)
 def binary(mctx, x):
 """File that appears to be binary (contains NUL bytes).
 """
 # i18n: "binary" is a keyword
 getargs(x, 0, 0, _("binary takes no arguments"))
 # i18n: "symlink" is a keyword
 getargs(x, 0, 0, _("symlink takes no arguments"))
 ctx = mctx.ctx
 return mctx.predicate(lambda f: ctx.flags(f) == 'l', predrepr='symlink')
-@predicate('resolved()', weight=10)
+@predicate('resolved()', weight=_WEIGHT_STATUS)
 def resolved(mctx, x):
 """File that is marked resolved according to :hg:`resolve -l`.
 """
 # i18n: "resolved" is a keyword
 getargs(x, 0, 0, _("resolved takes no arguments"))
 return mctx.never()
 ms = merge.mergestate.read(mctx.ctx.repo())
 return mctx.predicate(lambda f: f in ms and ms[f] == 'r',
 predrepr='resolved')
-@predicate('unresolved()', weight=10)
+@predicate('unresolved()', weight=_WEIGHT_STATUS)
 def unresolved(mctx, x):
 """File that is marked unresolved according to :hg:`resolve -l`.
 """
 # i18n: "unresolved" is a keyword
 getargs(x, 0, 0, _("unresolved takes no arguments"))
 return mctx.never()
 ms = merge.mergestate.read(mctx.ctx.repo())
 return mctx.predicate(lambda f: f in ms and ms[f] == 'u',
 predrepr='unresolved')
-@predicate('hgignore()', weight=10)
+@predicate('hgignore()', weight=_WEIGHT_STATUS)
 def hgignore(mctx, x):
 """File that matches the active .hgignore pattern.
 """
 # i18n: "hgignore" is a keyword
 getargs(x, 0, 0, _("hgignore takes no arguments"))
 return mctx.ctx.repo().dirstate._ignore
-@predicate('portable()', weight=0.5)
+@predicate('portable()', weight=_WEIGHT_CHECK_FILENAME)
 def portable(mctx, x):
 """File that has a portable name. (This doesn't include filenames with case
 collisions.)
 """
 # i18n: "portable" is a keyword
 getargs(x, 0, 0, _("portable takes no arguments"))
 return mctx.predicate(lambda f: util.checkwinfilename(f) is None,
 predrepr='portable')
-@predicate('grep(regex)', weight=30)
+@predicate('grep(regex)', weight=_WEIGHT_READ_CONTENTS)
 def grep(mctx, x):
 """File contains the given regular expression.
 """
 try:
 # i18n: "grep" is a keyword
 else:
 a = util.sizetoint(expr)
 b = _sizetomax(expr)
 return lambda x: x >= a and x <= b
-@predicate('size(expression)', weight=10)
+@predicate('size(expression)', weight=_WEIGHT_STATUS)
 def size(mctx, x):
 """File size matches the given expression. Examples:
 - size('1k') - files from 1024 to 2047 bytes
 - size('< 20k') - files less than 20480 bytes
 expr = getstring(x, _("size requires an expression"))
 m = sizematcher(expr)
 return mctx.fpredicate(lambda fctx: m(fctx.size()),
 predrepr=('size(%r)', expr), cache=True)
-@predicate('encoding(name)', weight=30)
+@predicate('encoding(name)', weight=_WEIGHT_READ_CONTENTS)
 def encoding(mctx, x):
 """File can be successfully decoded with the given character
 encoding. May not be useful for encodings other than ASCII and
 UTF-8.
 """
 except UnicodeDecodeError:
 return False
 return mctx.fpredicate(encp, predrepr=('encoding(%r)', enc), cache=True)
-@predicate('eol(style)', weight=30)
+@predicate('eol(style)', weight=_WEIGHT_READ_CONTENTS)
 def eol(mctx, x):
 """File contains newlines of the given style (dos, unix, mac). Binary
 files are excluded, files with mixed line endings match multiple
 styles.
 """
 def copiedp(fctx):
 p = fctx.parents()
 return p and p[0].path() != fctx.path()
 return mctx.fpredicate(copiedp, predrepr='copied', cache=True)
-@predicate('revs(revs, pattern)', weight=10)
+@predicate('revs(revs, pattern)', weight=_WEIGHT_STATUS)
 def revs(mctx, x):
 """Evaluate set in the specified revisions. If the revset match multiple
 revs, this will return file matching pattern in any of the revision.
 """
 # i18n: "revs" is a keyword
 return mctx.never()
 if len(matchers) == 1:
 return matchers[0]
 return matchmod.unionmatcher(matchers)
-@predicate('status(base, rev, pattern)', weight=10)
+@predicate('status(base, rev, pattern)', weight=_WEIGHT_STATUS)
 def status(mctx, x):
 """Evaluate predicate using status change between ``base`` and
 ``rev``. Examples:
 - ``status(3, 7, added())`` - matches files added from "3" to "7"

Mercurial > public > mercurial-scm > hg

comparison mercurial/fileset.py @ 38863:61ab546b71c3