Mercurial > public > mercurial-scm > hg
comparison mercurial/localrepo.py @ 24916:658bd4dc7a73
localrepo: have stream_in() not modify its argument
Localrepo's stream_in function modified its requirements argument. This is not
good practice because it may be unexpected behavior to the caller.
| author | Drew Gottlieb <drgott@google.com> |
|---|---|
| date | Wed, 22 Apr 2015 12:59:12 -0700 |
| parents | 1c40408770f7 |
| children | 71a738a6a1c1 |
comparison
equal
deleted
inserted
replaced
| 24915:1c40408770f7 | 24916:658bd4dc7a73 |
|---|---|
| 1825 util.bytecount(total_bytes / elapsed))) | 1825 util.bytecount(total_bytes / elapsed))) |
| 1826 | 1826 |
| 1827 # new requirements = old non-format requirements + | 1827 # new requirements = old non-format requirements + |
| 1828 # new format-related | 1828 # new format-related |
| 1829 # requirements from the streamed-in repository | 1829 # requirements from the streamed-in repository |
| 1830 requirements.update(self.requirements - self.supportedformats) | 1830 self.requirements = requirements | ( |
| 1831 self.requirements = requirements | 1831 self.requirements - self.supportedformats) |
| 1832 self._applyopenerreqs() | 1832 self._applyopenerreqs() |
| 1833 self._writerequirements() | 1833 self._writerequirements() |
| 1834 | 1834 |
| 1835 if rbranchmap: | 1835 if rbranchmap: |
| 1836 rbheads = [] | 1836 rbheads = [] |