Mercurial > public > mercurial-scm > hg
comparison mercurial/debugcommands.py @ 39244:73cf21b2e8a6
manifest: add getstorage() to manifestlog and use it globally
It is a common pattern to obtain a directory manifest storage instance
(a manifestrevlog) by going through manifestlog._revlog.dirlog().
Why access to storage and caching of other manifests is done through
manifestrevlog instead of manifestlog, I don't know.
This commit establishes a getstorage(tree) API on manifestlog and
imanifestlog that provides a public API for accessing manifest storage.
All consumers previously using private attributes have been updated
to use this new method.
.. api:: manifestlog now has a getstorage(tree) method
It should be used for obtaining an object representing the
manifest's storage implementation. Accessing
manifestlog._revlog should be avoided.
Differential Revision: https://phab.mercurial-scm.org/D4277
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Fri, 10 Aug 2018 15:01:06 -0700 |
parents | 26f3d075f36e |
children | cb9cf42c902f |
comparison
equal
deleted
inserted
replaced
39243:0d97530eb535 | 39244:73cf21b2e8a6 |
---|---|
1484 _('NODE')) | 1484 _('NODE')) |
1485 ], '') | 1485 ], '') |
1486 def debugmanifestfulltextcache(ui, repo, add=None, **opts): | 1486 def debugmanifestfulltextcache(ui, repo, add=None, **opts): |
1487 """show, clear or amend the contents of the manifest fulltext cache""" | 1487 """show, clear or amend the contents of the manifest fulltext cache""" |
1488 with repo.lock(): | 1488 with repo.lock(): |
1489 r = repo.manifestlog._revlog | 1489 r = repo.manifestlog.getstorage(b'') |
1490 try: | 1490 try: |
1491 cache = r._fulltextcache | 1491 cache = r._fulltextcache |
1492 except AttributeError: | 1492 except AttributeError: |
1493 ui.warn(_( | 1493 ui.warn(_( |
1494 "Current revlog implementation doesn't appear to have a " | 1494 "Current revlog implementation doesn't appear to have a " |