Mercurial > public > mercurial-scm > hg
comparison mercurial/debugcommands.py @ 42451:810f66b468cd
rust: module policy with importrust
We introduce two rust+c module policies and a new
`policy.importrust()` that makes use of them.
This simple approach provides runtime switching of
implementations, which is crucial for the performance
measurements such as those Octobus does with ASV.
It can also be useful for bug analysis.
It also has the advantage of making conditionals in
Rust callers more uniform, in particular
abstracting over specifics like `demandimport`
At this point, the build stays unchanged, with the rust-cpython based
`rustext` module being built if HGWITHRUSTEXT=cpython.
More transparency for the callers, i.e., just using
`policy.importmod` would be a much longer term and riskier
effort for the following reasons:
1. It would require to define common module boundaries
for the three or four cases (pure, c, rust+ext, cffi) and that
is premature with the Rust extension currently under heavy
development in areas that are outside the scope of the C extensions.
2. It would imply internal API changes that are not currently wished,
as the case of ancestors demonstrates.
3. The lack of data or property-like attributes (tp_member
and tp_getset) in current `rust-cpython` makes it impossible to
achieve direct transparent replacement of pure Python classes by
Rust extension code, meaning that the caller sometimes has to be able
to make adjustments or provide additional wrapping.
author | Georges Racinet <georges.racinet@octobus.net> |
---|---|
date | Wed, 29 May 2019 13:27:56 +0200 |
parents | 607a0de9bae3 |
children | 49998d5ba66a |
comparison
equal
deleted
inserted
replaced
42450:9d31581cc44e | 42451:810f66b468cd |
---|---|
1276 fm.write('hgmodulepolicy', _("checking module policy (%s)\n"), | 1276 fm.write('hgmodulepolicy', _("checking module policy (%s)\n"), |
1277 policy.policy) | 1277 policy.policy) |
1278 fm.write('hgmodules', _("checking installed modules (%s)...\n"), | 1278 fm.write('hgmodules', _("checking installed modules (%s)...\n"), |
1279 os.path.dirname(pycompat.fsencode(__file__))) | 1279 os.path.dirname(pycompat.fsencode(__file__))) |
1280 | 1280 |
1281 if policy.policy in ('c', 'allow'): | 1281 rustandc = policy.policy in ('rust+c', 'rust+c-allow') |
1282 rustext = rustandc # for now, that's the only case | |
1283 cext = policy.policy in ('c', 'allow') or rustandc | |
1284 nopure = cext or rustext | |
1285 if nopure: | |
1282 err = None | 1286 err = None |
1283 try: | 1287 try: |
1284 from .cext import ( | 1288 if cext: |
1285 base85, | 1289 from .cext import ( |
1286 bdiff, | 1290 base85, |
1287 mpatch, | 1291 bdiff, |
1288 osutil, | 1292 mpatch, |
1289 ) | 1293 osutil, |
1290 dir(bdiff), dir(mpatch), dir(base85), dir(osutil) # quiet pyflakes | 1294 ) |
1295 # quiet pyflakes | |
1296 dir(bdiff), dir(mpatch), dir(base85), dir(osutil) | |
1297 if rustext: | |
1298 from .rustext import ( | |
1299 ancestor, | |
1300 dirstate, | |
1301 ) | |
1302 dir(ancestor), dir(dirstate) # quiet pyflakes | |
1291 except Exception as inst: | 1303 except Exception as inst: |
1292 err = stringutil.forcebytestr(inst) | 1304 err = stringutil.forcebytestr(inst) |
1293 problems += 1 | 1305 problems += 1 |
1294 fm.condwrite(err, 'extensionserror', " %s\n", err) | 1306 fm.condwrite(err, 'extensionserror', " %s\n", err) |
1295 | 1307 |