Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 35251:91a7204631f1

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
contrib: ban find(1)'s -printf operator, as it is a GNU-ism Differential Revision: https://phab.mercurial-scm.org/D1598
author Augie Fackler <augie@google.com>
date Tue, 05 Dec 2017 16:44:20 -0500
parents 273907306a39
children e223c0438f89
comparison
equal deleted inserted replaced
35250:84607c8b5af8 35251:91a7204631f1
147 (r'\w = +\w', "only one space after = allowed"), 147 (r'\w = +\w', "only one space after = allowed"),
148 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), 148 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
149 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), 149 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
150 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), 150 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
151 (r'grep.* -[ABC]', "don't use grep's context flags"), 151 (r'grep.* -[ABC]', "don't use grep's context flags"),
152 (r'find.*-printf',
153 "don't use 'find -printf', it doesn't exist on BSD find(1)"),
152 ], 154 ],
153 # warnings 155 # warnings
154 [ 156 [
155 (r'^function', "don't use 'function', use old style"), 157 (r'^function', "don't use 'function', use old style"),
156 (r'^diff.*-\w*N', "don't use 'diff -N'"), 158 (r'^diff.*-\w*N', "don't use 'diff -N'"),