contrib/check-code.py
changeset 28219 97fe88806f6f
parent 28053 34a2944aac9b
child 28399 2af0156cebaa
equal deleted inserted replaced
28218:41dcd7545266 28219:97fe88806f6f
   243 #     "don't use underbars in identifiers"),
   243 #     "don't use underbars in identifiers"),
   244     (r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',
   244     (r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',
   245      "don't use camelcase in identifiers"),
   245      "don't use camelcase in identifiers"),
   246     (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
   246     (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
   247      "linebreak after :"),
   247      "linebreak after :"),
   248     (r'class\s[^( \n]+:', "old-style class, use class foo(object)"),
   248     (r'class\s[^( \n]+:', "old-style class, use class foo(object)",
       
   249      r'#.*old-style'),
   249     (r'class\s[^( \n]+\(\):',
   250     (r'class\s[^( \n]+\(\):',
   250      "class foo() creates old style object, use class foo(object)"),
   251      "class foo() creates old style object, use class foo(object)",
       
   252      r'#.*old-style'),
   251     (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist
   253     (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist
   252                             if k not in ('print', 'exec')),
   254                             if k not in ('print', 'exec')),
   253      "Python keyword is not a function"),
   255      "Python keyword is not a function"),
   254     (r',]', "unneeded trailing ',' in list"),
   256     (r',]', "unneeded trailing ',' in list"),
   255 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
   257 #    (r'class\s[A-Z][^\(]*\((?!Exception)',