Mercurial > public > mercurial-scm > hg
comparison mercurial/verify.py @ 47363:9823b3489e90
verify: use some intermediate variables instead of a multi-liner
This is shorter and easier to read as the indentation remains the same.
We extract the long message in a module level constant for clarity.
Differential Revision: https://phab.mercurial-scm.org/D10815
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Tue, 01 Jun 2021 09:09:01 +0200 |
| parents | fb43853975b4 |
| children | 80c690bf4953 |
comparison
equal
deleted
inserted
replaced
| 47362:fb43853975b4 | 47363:9823b3489e90 |
|---|---|
| 38 return f | 38 return f |
| 39 | 39 |
| 40 | 40 |
| 41 HINT_FNCACHE = _( | 41 HINT_FNCACHE = _( |
| 42 b'hint: run "hg debugrebuildfncache" to recover from corrupt fncache\n' | 42 b'hint: run "hg debugrebuildfncache" to recover from corrupt fncache\n' |
| 43 ) | |
| 44 | |
| 45 WARN_PARENT_DIR_UNKNOWN_REV = _( | |
| 46 b"parent-directory manifest refers to unknown revision %s" | |
| 43 ) | 47 ) |
| 44 | 48 |
| 45 | 49 |
| 46 class verifier(object): | 50 class verifier(object): |
| 47 def __init__(self, repo, level=None): | 51 def __init__(self, repo, level=None): |
| 370 # since we delete entry in `mflinkrevs` during iteration, any | 374 # since we delete entry in `mflinkrevs` during iteration, any |
| 371 # remaining entries are "missing". We need to issue errors for them. | 375 # remaining entries are "missing". We need to issue errors for them. |
| 372 changesetpairs = [(c, m) for m in mflinkrevs for c in mflinkrevs[m]] | 376 changesetpairs = [(c, m) for m in mflinkrevs for c in mflinkrevs[m]] |
| 373 for c, m in sorted(changesetpairs): | 377 for c, m in sorted(changesetpairs): |
| 374 if dir: | 378 if dir: |
| 375 self._err( | 379 self._err(c, WARN_PARENT_DIR_UNKNOWN_REV % short(m), label) |
| 376 c, | |
| 377 _( | |
| 378 b"parent-directory manifest refers to unknown" | |
| 379 b" revision %s" | |
| 380 ) | |
| 381 % short(m), | |
| 382 label, | |
| 383 ) | |
| 384 else: | 380 else: |
| 385 self._err( | 381 self._err( |
| 386 c, | 382 c, |
| 387 _(b"changeset refers to unknown revision %s") | 383 _(b"changeset refers to unknown revision %s") |
| 388 % short(m), | 384 % short(m), |