Mercurial > public > mercurial-scm > hg

comparison mercurial/hgweb/webcommands.py @ 19534:983bb4069004

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
hgweb: cleaner if conditions in changelog() function This removes unneeded extra nesting level and extra variable, which makes the code easier to understand.
author Alexander Plavin <alexander@plav.in>
date Fri, 19 Jul 2013 02:08:19 +0400
parents 9a020b354d93
children cf9e5e45c1d3
comparison
equal deleted inserted replaced
19533:9a020b354d93 19534:983bb4069004
191 def changelog(web, req, tmpl, shortlog=False): 191 def changelog(web, req, tmpl, shortlog=False):
192 192
193 query = '' 193 query = ''
194 if 'node' in req.form: 194 if 'node' in req.form:
195 ctx = webutil.changectx(web.repo, req) 195 ctx = webutil.changectx(web.repo, req)
196 else: 196 elif 'rev' in req.form:
197 if 'rev' in req.form: 197 query = req.form['rev'][0]
198 query = req.form['rev'][0]
199 hi = query
200 else:
201 hi = 'tip'
202 try: 198 try:
203 ctx = web.repo[hi] 199 ctx = web.repo[query]
204 except (error.RepoError, error.LookupError): 200 except (error.RepoError, error.LookupError):
205 return _search(web, req, tmpl) # XXX redirect to 404 page? 201 return _search(web, req, tmpl) # XXX redirect to 404 page?
202 else:
203 ctx = web.repo['tip']
206 204
207 def changelist(latestonly, **map): 205 def changelist(latestonly, **map):
208 revs = [] 206 revs = []
209 if pos != -1: 207 if pos != -1:
210 revs = web.repo.changelog.revs(pos, 0) 208 revs = web.repo.changelog.revs(pos, 0)