Mercurial > public > mercurial-scm > hg
comparison mercurial/cmdutil.py @ 33045:99c6c9fa9e6d
cmdutil: use named arguments for changeset_templater.__init__
This will make the API more extensible and easier to use.
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Sat, 24 Jun 2017 11:47:26 -0700 |
parents | 6d79e9109908 |
children | 05906b8e1d23 |
comparison
equal
deleted
inserted
replaced
33044:1d2b68952950 | 33045:99c6c9fa9e6d |
---|---|
1575 self.ui.write("\n }") | 1575 self.ui.write("\n }") |
1576 | 1576 |
1577 class changeset_templater(changeset_printer): | 1577 class changeset_templater(changeset_printer): |
1578 '''format changeset information.''' | 1578 '''format changeset information.''' |
1579 | 1579 |
1580 def __init__(self, ui, repo, tmplspec, matchfn, diffopts, buffered): | 1580 # Arguments before "buffered" used to be positional. Consider not |
1581 # adding/removing arguments before "buffered" to not break callers. | |
1582 def __init__(self, ui, repo, tmplspec, matchfn=None, diffopts=None, | |
1583 buffered=False): | |
1584 diffopts = diffopts or {} | |
1585 | |
1581 changeset_printer.__init__(self, ui, repo, matchfn, diffopts, buffered) | 1586 changeset_printer.__init__(self, ui, repo, matchfn, diffopts, buffered) |
1582 self.t = formatter.loadtemplater(ui, tmplspec, | 1587 self.t = formatter.loadtemplater(ui, tmplspec, |
1583 cache=templatekw.defaulttempl) | 1588 cache=templatekw.defaulttempl) |
1584 self._counter = itertools.count() | 1589 self._counter = itertools.count() |
1585 self.cache = {} | 1590 self.cache = {} |
1692 return formatter.lookuptemplate(ui, 'changeset', tmpl) | 1697 return formatter.lookuptemplate(ui, 'changeset', tmpl) |
1693 | 1698 |
1694 def makelogtemplater(ui, repo, tmpl, buffered=False): | 1699 def makelogtemplater(ui, repo, tmpl, buffered=False): |
1695 """Create a changeset_templater from a literal template 'tmpl'""" | 1700 """Create a changeset_templater from a literal template 'tmpl'""" |
1696 spec = logtemplatespec(tmpl, None) | 1701 spec = logtemplatespec(tmpl, None) |
1697 return changeset_templater(ui, repo, spec, matchfn=None, diffopts={}, | 1702 return changeset_templater(ui, repo, spec, buffered=buffered) |
1698 buffered=buffered) | |
1699 | 1703 |
1700 def show_changeset(ui, repo, opts, buffered=False): | 1704 def show_changeset(ui, repo, opts, buffered=False): |
1701 """show one changeset using template or regular display. | 1705 """show one changeset using template or regular display. |
1702 | 1706 |
1703 Display format will be the first non-empty hit of: | 1707 Display format will be the first non-empty hit of: |