Mercurial > public > mercurial-scm > hg
comparison hgext/patchbomb.py @ 33436:9bb4decd43b0
repovfs: add a ward to check if locks are properly taken
When the appropriate developer warnings are enabled, We wrap 'repo.vfs.audit' to
check for locks when accessing file in '.hg' for writing. Another changeset will
add a 'ward' for the store vfs (svfs).
This check system has caught a handful of locking issues that have been fixed
in previous series (mostly in 4.0). I expect another batch to be caught in third
party extensions.
We introduce two real exceptions from extensions 'blackbox.log' (because a lot of
read-only operations add entry to it), and 'last-email.txt' (because 'hg email'
is currently a read only operation and there is value to keep it this way).
In addition we are currently allowing bisect to operate outside of the lock
because the current code is a bit hard to get properly locked for now. Multiple
clean up have been made but there is still a couple of them to do and the freeze
is coming.
author | Boris Feld <boris.feld@octobus.net> |
---|---|
date | Tue, 11 Jul 2017 12:38:17 +0200 |
parents | 3abba5bc3454 |
children | 6e6452bc441d |
comparison
equal
deleted
inserted
replaced
33435:456626e9c3d1 | 33436:9bb4decd43b0 |
---|---|
120 | 120 |
121 def uisetup(ui): | 121 def uisetup(ui): |
122 cmdutil.extraexport.append('pullurl') | 122 cmdutil.extraexport.append('pullurl') |
123 cmdutil.extraexportmap['pullurl'] = _addpullheader | 123 cmdutil.extraexportmap['pullurl'] = _addpullheader |
124 | 124 |
125 def reposetup(ui, repo): | |
126 if not repo.local(): | |
127 return | |
128 repo._wlockfreeprefix.add('last-email.txt') | |
125 | 129 |
126 def prompt(ui, prompt, default=None, rest=':'): | 130 def prompt(ui, prompt, default=None, rest=':'): |
127 if default: | 131 if default: |
128 prompt += ' [%s]' % default | 132 prompt += ' [%s]' % default |
129 return ui.prompt(prompt + rest, default) | 133 return ui.prompt(prompt + rest, default) |