Mercurial > public > mercurial-scm > hg
comparison mercurial/bundle2.py @ 34249:ab379eed2e31
bundle2: raise a more helpful error if building a bundle part header fails
I've tripped on this several times now, and am tired of debugging. Now
the header parts are part of the error message when the ''.join()
fails, which makes debugging obvious.
| author | Augie Fackler <raf@durin42.com> |
|---|---|
| date | Fri, 15 Sep 2017 18:37:29 -0400 |
| parents | 8e0358024a36 |
| children | e71890f27767 |
comparison
equal
deleted
inserted
replaced
| 34248:b59620c52eec | 34249:ab379eed2e31 |
|---|---|
| 1048 header.append(value) | 1048 header.append(value) |
| 1049 for key, value in advpar: | 1049 for key, value in advpar: |
| 1050 header.append(key) | 1050 header.append(key) |
| 1051 header.append(value) | 1051 header.append(value) |
| 1052 ## finalize header | 1052 ## finalize header |
| 1053 headerchunk = ''.join(header) | 1053 try: |
| 1054 headerchunk = ''.join(header) | |
| 1055 except TypeError: | |
| 1056 raise TypeError(r'Found a non-bytes trying to ' | |
| 1057 r'build bundle part header: %r' % header) | |
| 1054 outdebug(ui, 'header chunk size: %i' % len(headerchunk)) | 1058 outdebug(ui, 'header chunk size: %i' % len(headerchunk)) |
| 1055 yield _pack(_fpartheadersize, len(headerchunk)) | 1059 yield _pack(_fpartheadersize, len(headerchunk)) |
| 1056 yield headerchunk | 1060 yield headerchunk |
| 1057 ## payload | 1061 ## payload |
| 1058 try: | 1062 try: |