Mercurial > public > mercurial-scm > hg
comparison mercurial/worker.py @ 22199:b3e51675f98e
cleanup: avoid _ for local unused tmp variables - that is reserved for i18n
_ is usually used for i18n markup but we also used it for I-don't-care
variables.
Instead, name don't-care variables in a slightly descriptive way but use the _
prefix to designate unused variable.
This will mute some pyflakes "import '_' ... shadowed by loop variable"
warnings.
author | Mads Kiilerich <madski@unity3d.com> |
---|---|
date | Fri, 15 Aug 2014 16:20:47 +0200 |
parents | 1e5b38a919dd |
children | 328739ea70c3 |
comparison
equal
deleted
inserted
replaced
22198:77142de48ae4 | 22199:b3e51675f98e |
---|---|
103 os.kill(p, signal.SIGTERM) | 103 os.kill(p, signal.SIGTERM) |
104 except OSError, err: | 104 except OSError, err: |
105 if err.errno != errno.ESRCH: | 105 if err.errno != errno.ESRCH: |
106 raise | 106 raise |
107 def waitforworkers(): | 107 def waitforworkers(): |
108 for _ in pids: | 108 for _pid in pids: |
109 st = _exitstatus(os.wait()[1]) | 109 st = _exitstatus(os.wait()[1]) |
110 if st and not problem[0]: | 110 if st and not problem[0]: |
111 problem[0] = st | 111 problem[0] = st |
112 killworkers() | 112 killworkers() |
113 t = threading.Thread(target=waitforworkers) | 113 t = threading.Thread(target=waitforworkers) |