Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 25588:b40071379c5b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: ban use of '[[ ]]' in tests
author Yuya Nishihara <yuya@tcha.org>
date Tue, 16 Jun 2015 23:06:30 +0900
parents a39c35e8e559
children d60678a567a9
comparison
equal deleted inserted replaced
25587:49fb24f72747 25588:b40071379c5b
112 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"), 112 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
113 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), 113 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
114 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 114 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
115 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 115 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
116 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), 116 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
117 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),
117 (r'^alias\b.*=', "don't use alias, use a function"), 118 (r'^alias\b.*=', "don't use alias, use a function"),
118 (r'if\s*!', "don't use '!' to negate exit status"), 119 (r'if\s*!', "don't use '!' to negate exit status"),
119 (r'/dev/u?random', "don't use entropy, use /dev/zero"), 120 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
120 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"), 121 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
121 (r'^( *)\t', "don't use tabs to indent"), 122 (r'^( *)\t', "don't use tabs to indent"),