Mercurial > public > mercurial-scm > hg
comparison mercurial/commandserver.py @ 38291:c07424ec633c
commandserver: close server's fds explicitly from a worker
The forked worker does not need to accept connections from the server's
socket fd. So let's just close them explicitly to avoid surprises.
Differential Revision: https://phab.mercurial-scm.org/D3720
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Tue, 12 Jun 2018 12:41:09 -0700 |
| parents | 6f9ac3cb0987 |
| children | afc4ad706f9c |
comparison
equal
deleted
inserted
replaced
| 38290:b5651ae53127 | 38291:c07424ec633c |
|---|---|
| 492 h.newconnection() | 492 h.newconnection() |
| 493 finally: | 493 finally: |
| 494 conn.close() # release handle in parent process | 494 conn.close() # release handle in parent process |
| 495 else: | 495 else: |
| 496 try: | 496 try: |
| 497 selector.close() | |
| 498 self._sock.close() | |
| 497 self._runworker(conn) | 499 self._runworker(conn) |
| 498 conn.close() | 500 conn.close() |
| 499 os._exit(0) | 501 os._exit(0) |
| 500 except: # never return, hence no re-raises | 502 except: # never return, hence no re-raises |
| 501 try: | 503 try: |