Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 35087:dd000a958364

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: grep's context flags don't need an extra space before number A bit of useless trivia found while researching this: OpenBSD's grep's -C has a default value (of 2) and disallows space before the argument (while -A and -B allow).
author Anton Shestakov <av6@dwimlabs.net>
date Sat, 18 Nov 2017 13:00:47 +0800
parents 0b46352384a0
children 273907306a39
comparison
equal deleted inserted replaced
35086:8db4ca768416 35087:dd000a958364
146 (r'\|&', "don't use |&, use 2>&1"), 146 (r'\|&', "don't use |&, use 2>&1"),
147 (r'\w = +\w', "only one space after = allowed"), 147 (r'\w = +\w', "only one space after = allowed"),
148 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), 148 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
149 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), 149 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
150 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), 150 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
151 (r'grep.* -[ABC] ', "don't use grep's context flags"), 151 (r'grep.* -[ABC]', "don't use grep's context flags"),
152 ], 152 ],
153 # warnings 153 # warnings
154 [ 154 [
155 (r'^function', "don't use 'function', use old style"), 155 (r'^function', "don't use 'function', use old style"),
156 (r'^diff.*-\w*N', "don't use 'diff -N'"), 156 (r'^diff.*-\w*N', "don't use 'diff -N'"),