Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 29136:e05bdc01505f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: add a rule banning `env -u`
author Kevin Bullock <kbullock+mercurial@ringworld.org>
date Fri, 06 May 2016 08:45:56 -0500
parents 75309badb485
children c07be448028b
comparison
equal deleted inserted replaced
29135:3879d02cd1cc 29136:e05bdc01505f
131 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"), 131 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
132 (r'\butil\.Abort\b', "directly use error.Abort"), 132 (r'\butil\.Abort\b', "directly use error.Abort"),
133 (r'\|&', "don't use |&, use 2>&1"), 133 (r'\|&', "don't use |&, use 2>&1"),
134 (r'\w = +\w', "only one space after = allowed"), 134 (r'\w = +\w', "only one space after = allowed"),
135 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"), 135 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
136 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'")
136 ], 137 ],
137 # warnings 138 # warnings
138 [ 139 [
139 (r'^function', "don't use 'function', use old style"), 140 (r'^function', "don't use 'function', use old style"),
140 (r'^diff.*-\w*N', "don't use 'diff -N'"), 141 (r'^diff.*-\w*N', "don't use 'diff -N'"),