comparison contrib/check-code.py @ 16494:e1f0305eabe4 stable

tests: don't use /dev/urandom for largefiles testing There is no need to use entropy here just to create some content that only will be used for hashing and ignored. This avoids a problem where dd from /dev/urandom on solaris generates too short output.
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 23 Apr 2012 01:56:48 +0200
parents 4fe874697a4d
children 5f9835ed3d6d
comparison
equal deleted inserted replaced
16493:72c6240a4b7d 16494:e1f0305eabe4
72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
73 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 73 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
74 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), 74 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
75 (r'^alias\b.*=', "don't use alias, use a function"), 75 (r'^alias\b.*=', "don't use alias, use a function"),
76 (r'if\s*!', "don't use '!' to negate exit status"), 76 (r'if\s*!', "don't use '!' to negate exit status"),
77 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
77 ], 78 ],
78 # warnings 79 # warnings
79 [] 80 []
80 ] 81 ]
81 82